Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized the XRTracker by reusing XRPose objects to minimize garbage collection overhead in C# #80198

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Optimized the XRTracker by reusing XRPose objects to minimize garbage collection overhead in C# #80198

merged 1 commit into from
Aug 3, 2023

Conversation

Faolan-Rad
Copy link
Contributor

This change enhances performance by avoiding unnecessary memory allocations, by reusing the XRPose that is already there.

@Faolan-Rad Faolan-Rad requested a review from a team as a code owner August 3, 2023 02:00
@YeldhamDev YeldhamDev added this to the 4.2 milestone Aug 3, 2023
BastiaanOlij
BastiaanOlij approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@akien-mga akien-mga merged commit 789b392 into godotengine:master Aug 3, 2023
14 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BastiaanOlij BastiaanOlij BastiaanOlij approved these changes

Assignees
No one assigned
Labels
enhancement topic:xr
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Faolan-Rad @akien-mga @BastiaanOlij @YeldhamDev